[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

[Phoebe Wang via Phabricator via cfe-commits]

pengfei added inline comments.


================
Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c:1
+// RUN: %clang_cc1 -ffreestanding %s -O0 -triple=x86_64-apple-darwin -target-feature +avx512bw -target-feature +avx512vl -emit-llvm -o - -Wall -Werror | FileCheck %s
+
----------------
Should the name starts with `avx512bwvl`?
Or put them into `avx512bwvl-intrinsics.ll`?


================
Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceMinMaxIntrin.c:1
+// RUN: %clang_cc1 -ffreestanding %s -O0 -triple=x86_64-apple-darwin -target-feature +avx512bw -target-feature +avx512vl -emit-llvm -o - -Wall -Werror | FileCheck %s
+
----------------
Maybe not worth a new file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140531/new/

https://reviews.llvm.org/D140531