[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

Wed Dec 21 15:02:03 PST 2022

arsenm closed this revision.
arsenm added a comment.

437346abe18ec4fc982ae36f6821487dafc1a06e <https://reviews.llvm.org/rG437346abe18ec4fc982ae36f6821487dafc1a06e>

================
Comment at: clang/docs/LanguageExtensions.rst:644
                                              magnitude than x
+ T__builtin_elementwise_canonicalize(T x)  return the platform specific canonical encoding of a floating-point number             floating point types
+
----------------
fhahn wrote:
> arsenm wrote:
> > fhahn wrote:
> > > I think this needs re-flowing , otherwise the table won't be rendered properly? Same for the next line
> > I'm not really sure what's going on with the formatting or how this works. It looks worse on Phabricator than in the editor 
> I just tried this locally and the entries seem to be mis-aligned, which gets rejected by `sphinx`:
> 
> ```
> Warning, treated as error:
> ../tools/clang/docs/LanguageExtensions.rst:644:Malformed table.
> Text in column margin in table line 16.
> ```
It builds for me (although the line wrapping for these and the others are awkward, splitting the parameter names). Probably need to specifically widen the name column

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139640/new/

https://reviews.llvm.org/D139640