[PATCH] D137838: [Support] Move TargetParsers to new component

Sam Elliott via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 21 14:29:09 PST 2022


lenary added a comment.

In D137838#4010987 <https://reviews.llvm.org/D137838#4010987>, @dblaikie wrote:

> This has introduced a circular dependency due to the forwarding header (forwarding header depends on new lib, new lib depends on support, where the forwarding header is). Generally this wouldn't be acceptable (& I'd suggest the patch be reverted on that basis) though I understand this is a complicated migration - what's the timeline for correcting this issue?

A commit was landed to add TargetParser to the module map so it looks like part of Support, which solves the circular dependency issue in the short term, I believe.

https://reviews.llvm.org/D140420 is a proposed fix which should more clearly split the TargetParser from Support, but I'm not super familiar with modules and my linux dev environment does not work with a modules build. I'd appreciate any comments or guidance though I also know it needs an update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137838/new/

https://reviews.llvm.org/D137838



More information about the cfe-commits mailing list