[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

Wed Dec 21 08:09:59 PST 2022

ilinpv added a comment.

In D127812#4009577 <https://reviews.llvm.org/D127812#4009577>, @hctim wrote:

> In D127812#4009447 <https://reviews.llvm.org/D127812#4009447>, @hctim wrote:
>
>> Hi, this looks like a candidate for breaking the MSan bot: https://lab.llvm.org/buildbot/#/builders/5/builds/30139
>>
>> Still looking into it and bisecting, will let you know when I have more info. To reproduce the bots, the best way (because MSan setup is tricky because it requires an instrumented libcxx) is to use the scripts from https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild (buildbot_fast.sh is the right one).
>
> Yeah, unfortunately I did track this failure down to this commit and reverted it upstream. If you need help figuring it out, please let me know. You may find that adding `-fsanitize-memory-track-origins=2` useful to add to the buildscript as well (which can be done by changing `check_stage2_msan` to `check_stage2_msan_track_origins` in `buildbot_fast.sh`.

It would be great to have more details how to setup up your bot, using buildbot_fast.sh on x86_64 Ubuntu 22.04 LTS leads to error ( pthreads installed ):

  CMake Error at /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Could NOT find Threads (missing: Threads_FOUND)
  Call Stack (most recent call first):
    /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
    /usr/share/cmake-3.22/Modules/FindThreads.cmake:238 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
    cmake/config-ix.cmake:114 (find_package)
    CMakeLists.txt:776 (include)

Also MemorySanitizer: use-of-uninitialized-value cases from https://lab.llvm.org/buildbot/#/builders/5/builds/30139 looks fine locally, all values initialized, could MSAN produce false positive results?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127812/new/

https://reviews.llvm.org/D127812