[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

Wed Dec 21 05:25:34 PST 2022

arsenm added a comment.

In D140467#4010507 <https://reviews.llvm.org/D140467#4010507>, @arsenm wrote:

> In D140467#4010378 <https://reviews.llvm.org/D140467#4010378>, @pengfei wrote:
>
>> Use FastMathFlagGuard instead, thanks @foad!
>>
>> In D140467#4010296 <https://reviews.llvm.org/D140467#4010296>, @arsenm wrote:
>>
>>> Needs tests. I couldn’t find any for the base builtins either
>>
>> I don't think so. We have tested their intrinsic wrappers, e.g., https://github.com/llvm/llvm-project/blob/main/clang/test/CodeGen/X86/avx512fp16-builtins.c#L4451
>
> These are not testing use of these builtins correctly

This test amounts to a builtin header test for immintrin.h. This should move to clang/test/Headers and replaced with a builtin test directly checking the builtin handling

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140467/new/

https://reviews.llvm.org/D140467