[PATCH] D140380: [include-cleaner] Respect IWYU pragmas during analyze

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 20 01:53:38 PST 2022


kadircet added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:184
 #include "b.h"
+#include "keep.h" // IWYU pragma: keep
 
----------------
hokein wrote:
> add the `export` case as well.
i don't think we should be testing the behaviour of `PragmaIncludes::shouldKeep` here, hence i think one example is enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140380/new/

https://reviews.llvm.org/D140380



More information about the cfe-commits mailing list