[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 19 22:33:10 PST 2022


ChuanqiXu added a comment.

> So it's not a change that breaks existing code - because no-one has Header Units in existing code.

We can't assume this. Since we already said people can try to use header units in clang15. We can't assume there is nobody using header units just because they don't tell us. In fact, I've seen some bug reports about header units recently. So there are people (try to) using header units at least. So I think we should better to mark it in the potential breaking section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140261/new/

https://reviews.llvm.org/D140261



More information about the cfe-commits mailing list