[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

[Mikael Holmén via Phabricator via cfe-commits]

uabelho added a comment.

In D138253#4006197 <https://reviews.llvm.org/D138253#4006197>, @NoQ wrote:

> Also if you're compiling your code with `-Weverything` by default, I do recommend explicitly disabling `-Wunsafe-buffer-usage` for at least a month or so, until we land all the basic functionality and you can make an informed decision whether you actually need it (more reading in https://discourse.llvm.org/t/rfc-c-buffer-hardening/65734 and D136811 <https://reviews.llvm.org/D136811>).
>
> But, yeah, we still shouldn't break users who simply want to enable `-Weverything` temporarily just to see what warnings are there, that's really bad and I hope I'll patch this up today.

Thanks for the warning. In our fuzzy testing we sometimes randomly use -Weverything just to make sure it doesn't crash. And well, it did crash here, so I guess the testing was succesful :)
So it's no panic for us, but good to sort out the crash.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138253/new/

https://reviews.llvm.org/D138253