[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

[John McCall via Phabricator via cfe-commits]

rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

Oh, I see.  That's a really unfortunate way to end up emitting this code pattern, since ignoring the result is so common.  To fix that, we'd have to either figure out the result was unused in Sema or do a relatively complex analysis in IRGen, though.

Anyway, not something we have to do in this patch.  LGTM.

We should reconsider the rules we use for temporary destruction one of these days, though.  The current pattern is very error-prone, especially in the presence of exceptions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136639/new/

https://reviews.llvm.org/D136639