[PATCH] D140261: [C++20][Modules] Do not allow non-inline external definitions in header units.

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added a comment.

In D140261#4004542 <https://reviews.llvm.org/D140261#4004542>, @iains wrote:

> OK so this is what I plan to land assuming testing goes OK.
> I suspect that this might cause some user code to flag errors - there are quite a number of ODR violations "in the wild".

I forgot we need to mention such changes in https://clang.llvm.org/docs/ReleaseNotes.html#potentially-breaking-changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140261/new/

https://reviews.llvm.org/D140261