[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional
Sergei Barannikov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 19 14:58:42 PST 2022
barannikov88 accepted this revision.
barannikov88 added inline comments.
================
Comment at: llvm/lib/CodeGen/RegAllocGreedy.h:83
public:
- ExtraRegInfo() = default;
+ ExtraRegInfo() {}
ExtraRegInfo(const ExtraRegInfo &) = delete;
----------------
bkramer wrote:
> barannikov88 wrote:
> > Is it somehow different than ' = default'?
> It makes the class non-trivial, std::optional::emplace has issues with trivial default constructors :(
Ah, right, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140332/new/
https://reviews.llvm.org/D140332
More information about the cfe-commits
mailing list