[PATCH] D140292: [OpenMP] Migrate OpenMPOffloadMappingFlags from Clang CodeGen to OMPConstants
Johannes Doerfert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 19 11:03:29 PST 2022
jdoerfert added inline comments.
================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:193
- OMP_TGT_EXEC_MODE_GENERIC | OMP_TGT_EXEC_MODE_SPMD,
- LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue */ OMP_TGT_EXEC_MODE_GENERIC_SPMD)
};
----------------
TIFitis wrote:
> I am not sure if this change is safe. It can be avoided by making `OpenMPOffloadMappingFlags` an enum class.
Why do you need to change this enum at all?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140292/new/
https://reviews.llvm.org/D140292
More information about the cfe-commits
mailing list