[PATCH] D140290: [clang-tidy] Add misc-static-declaration-in-header check
Carlos Galvez via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 19 09:10:44 PST 2022
carlosgalvezp added inline comments.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/static-declaration-in-header.rst:39
+ A semicolon-separated list of filename extensions of header files (the filename
+ extensions should not include "." prefix). Default is ";h;hh;hpp;hxx".
+ For extension-less header files, using an empty string or leaving an
----------------
carlosgalvezp wrote:
> Eugene.Zelenko wrote:
> > Please replace quotes with single back-ticks.
> There's 3 other such instances of this pattern:
>
> - 1 of them has: ``";...."`` (double back tick followed by quotes).
> - 2 of them have it like I wrote it here.
>
> None of them follow the format you propose, so I'd be reluctant to introduce a third convention :) Would it be OK to keep the most prominent format for consistency, and fix the formatting for all in a separate patch?
Sorry, there's 2, not 3 (the third one is this check :) )
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140290/new/
https://reviews.llvm.org/D140290
More information about the cfe-commits
mailing list