[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 19 03:30:08 PST 2022


Szelethus added a comment.

In D137790#3992216 <https://reviews.llvm.org/D137790#3992216>, @balazske wrote:

> Some reports can be found here <https://codechecker-demo.eastus.cloudapp.azure.com/Default/runs> (if the link works and the data does not expire), the runs stored on 2022-12-09.
>
> Results appeared only projects "postgres" and "curl" (from memcached,tmux,curl,twin,vim,openssl,sqlite,ffmpeg,postgres,libwebm) from checkers **StdCLibraryFunctionArgs** and **Errno**.
>
> On the postgres results, the second is one that can be fixed in the checker (add special cases to `StdLibraryFunctionsChecker` for zero `len` or `size` `fread` and `fwrite` arguments). The others are false positives because the error path is impossible because implicit constraints (what is not known to the analyzer) on variables.
>
> These curl <https://codechecker-demo.eastus.cloudapp.azure.com/Default/reports?review-status=Unreviewed&review-status=Confirmed%20bug&detection-status=New&detection-status=Reopened&detection-status=Unresolved&run=curl_curl-7_66_0_baseline&is-unique=off&diff-type=New&checker-name=alpha.unix.Errno> results look faulty, the last `fclose` call looks not recognized.

Please make the link a little more reviewer friendly. You can make a CodeChecker URL where the appropriate runs are already selected, with the appropriate checkers being filtered, and uniquing turned on, like this:
https://codechecker-demo.eastus.cloudapp.azure.com/Default/reports?run=libwebm_libwebm-1.0.0.27_baseline&run=postgres_REL_13_0_baseline&run=ffmpeg_n4.3.1_baseline&run=sqlite_version-3.33.0_baseline&run=openssl_openssl-3.0.0-alpha7_baseline&run=vim_v8.2.1920_baseline&run=twin_v0.8.1_baseline&run=curl_curl-7_66_0_baseline&run=tmux_2.6_baseline&run=memcached_1.6.8_baseline&is-unique=on&diff-type=New&checker-name=alpha.unix.Errno&checker-name=alpha.unix.StdCLibraryFunctionArgs

Also, I'd appreciate links to the specific reports you are describing. I'm not sure what postgres results you are talking about, because I suspect I listed them differently. You made a link to the curl result, so please do it for the others as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137790/new/

https://reviews.llvm.org/D137790



More information about the cfe-commits mailing list