[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.
Fahad Nayyar via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 19 02:20:12 PST 2022
fahadnayyar marked an inline comment as done.
fahadnayyar added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:14115
+/// Analyze the given compound assignment for the possible losing of
+/// floating-point precision.
----------------
aaron.ballman wrote:
> Moving this function to another spot in the file makes comparing the new and old code pretty hard -- would it make more sense to forward declare the needed static functions so this can stay where it was and it's easier to see what's changed?
@aaron.ballman I've made the required changes. Please have a look, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139114/new/
https://reviews.llvm.org/D139114
More information about the cfe-commits
mailing list