[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration
Thorsten via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Dec 18 22:54:56 PST 2022
tschuett added inline comments.
================
Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:24
+namespace clang {
+namespace clangd {
+namespace {
----------------
You can merge this into `namespace clang::clangd`.
================
Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:58
+};
+
+REGISTER_TWEAK(AddDoxygenComment)
----------------
The LLVM coding style kindly asks you stop the anonymous namespace here. Furthermore, I believe that the `REGISTER_TWEAK` does not work in an anonymous namespace.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140275/new/
https://reviews.llvm.org/D140275
More information about the cfe-commits
mailing list