[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

Phoebe Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 17 08:02:11 PST 2022


pengfei added a comment.

In D139701#3993446 <https://reviews.llvm.org/D139701#3993446>, @arsenm wrote:

> TargetCodeGenInfo::setTargetAttributes already exists as a place for targets to emit their custom attributes, x86 could emit it there

It's an attractive suggestion. But it's not easy to move it into target code because the value is not a static one but calculated during codegen. As I explained in LangRef, the value is `max(maxVectorWidthInArgsRet(CurFn), maxVectorWidthInArgsRet(Callee0), maxVectorWidthInArgsRet(Callee1), ...)`. We may need to copy/paste a lot of codegen code there to achieve the same goal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139701/new/

https://reviews.llvm.org/D139701



More information about the cfe-commits mailing list