[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 16 12:32:21 PST 2022


ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:2683
+        OMPDeclareTargetDeclAttr::getDeviceType(VariantFD->getMostRecentDecl());
+    if (!DevTy || *DevTy == OMPDeclareTargetDeclAttr::DT_Host)
+      return true;
----------------
doru1004 wrote:
> ABataev wrote:
> > Do you have a test for `!DevTy` case? Maybe I'm missing it.
> Yes it was the first test I added. The second one tests the second part of the condition.
Hmm, but in this test we have *DevTy == OMPDeclareTargetDeclAttr::DT_Host, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140155/new/

https://reviews.llvm.org/D140155



More information about the cfe-commits mailing list