[PATCH] D140191: [CodeComplete] Offer completions for headers with extension .hxx in include directives

[Nathan Ridge via Phabricator via cfe-commits]

nridge added inline comments.


================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:10020
         // Only files that really look like headers. (Except in special dirs).
         // Header extensions from Types.def, which we can't depend on here.
         const bool IsHeader = Filename.endswith_insensitive(".h") ||
----------------
kadircet wrote:
> this isn't actually the extensions from `Types.def` (it only has `h` and `hh`). you mind rewording it as `This has some extra common file extensions that aren't part of Types.def`?
I ended up removing the reference to Types.def altogether because it didn't seem to be adding any value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140191/new/

https://reviews.llvm.org/D140191