[PATCH] D139717: Revert "[Driver] Remove Joined -X"

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 16 09:14:27 PST 2022


MaskRay added a comment.

In D139717#3999098 <https://reviews.llvm.org/D139717#3999098>, @rsundahl wrote:

> Added the test warn-not-error-Xfoo

`-Xfoo` leads to a warning (expected) which is weird. Can you change it to a form which actually reflects how `-X` is used? (aka `-Xparser`)

I am not sure adding arbitrary `-X*` which leads to a `-Wunused-command-line-argument` warning is useful. It certainly leads to confusion why this is supported at all, if the needs are just `-Xparser`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139717/new/

https://reviews.llvm.org/D139717



More information about the cfe-commits mailing list