[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

Fri Dec 16 06:36:51 PST 2022

dzhidzhoev reopened this revision.
dzhidzhoev added a comment.
This revision is now accepted and ready to land.

In D139741#4000201 <https://reviews.llvm.org/D139741#4000201>, @rupprecht wrote:

> I'm not sure what the libcxx failure was that caused you to revert this, but we also saw a clang crasher as a result of this. `clang/lib/AST/Decl.cpp:4300 in unsigned int clang::FieldDecl::getBitWidthValue(const ASTContext &) const: isBitField() && "not a bitfield"`. I'll try to reduce it.

Thank you!
The problem was that we should not try to get the base subobject class of union fields.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139741/new/

https://reviews.llvm.org/D139741