[PATCH] D139006: [UpdateTestChecks] Match define for labels

[Nikita Popov via Phabricator via cfe-commits]

nikic added a comment.

In D139006#3999984 <https://reviews.llvm.org/D139006#3999984>, @jdoerfert wrote:

> Why not just `--function-define` as a way to enable the `define` but not the `captures`, if that is really something necessary.
> It is unclear to me why `function-signature` is not sufficient here and what the big problem with using it is.

I believe the motivation here is the default behavior: Experienced contributors know how to recognize this problem and use `--function-signature` to avoid it, but new contributors will not be aware of it, and the error message produced by FileCheck is not super helpful.

That's why I'm suggesting to change the default behavior for new tests, and @spatel suggests to add detection for the scenario and a warning that tells you to use `--function-signature`. Either of those should address the discoverability issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139006/new/

https://reviews.llvm.org/D139006