[PATCH] D140002: [C++20] [Modules] Merging of lambda types in deserialization

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai added a comment.

Test case MergeLambdas3.cppm is unstable. Sometimes it passes but usually it fails.



================
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:2161-2198
+  /// FIXME: The `DeclContext::noload_lookup()` wouldn't load local lexical
+  /// lookups since unnamed declarations are skipped. We can find this in
+  /// `DeclContext::buildLookupImpl` and `shouldBeHidden(NamedDecl*)` in
+  /// DeclBase.cpp. So the `DeclContext::noload_lookup()` here can only find
+  /// decls during the deserilizations. For example:
+  ///
+  /// ```
----------------
ChuanqiXu wrote:
> The comment tells why this is a workaround and what we need to do to fix the problem properly.
Is there are a test covering this workaround? I've removed it and see no new test failures.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140002/new/

https://reviews.llvm.org/D140002