[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

[Qiongsi Wu via Phabricator via cfe-commits]

qiongsiwu1 updated this revision to Diff 483146.
qiongsiwu1 added a comment.

Addressing review comments. Thanks for the review @nemanjai !!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140080/new/

https://reviews.llvm.org/D140080

Files:
  clang/lib/Driver/ToolChains/Arch/PPC.cpp
  clang/test/Driver/ppc-cpus.c


Index: clang/test/Driver/ppc-cpus.c
===================================================================
--- clang/test/Driver/ppc-cpus.c
+++ clang/test/Driver/ppc-cpus.c
@@ -31,3 +31,9 @@
 
 // RUN: %clang -### -c --target=powerpc64 %s -mcpu=generic -mtune=pwr9 2>&1 | FileCheck %s --check-prefix=TUNE
 // TUNE: "-target-cpu" "ppc64" "-tune-cpu" "pwr9"
+
+/// Test mcpu options that are equivalent to "generic"
+// RUN: %clang -### -c -target powerpc64 %s -mcpu=generic 2>&1 | FileCheck %s --check-prefix=GENERIC
+// RUN: %clang -### -c -target powerpc64 %s -mcpu=405     2>&1 | FileCheck %s --check-prefix=GENERIC
+//
+// GENERIC: "-target-cpu" "ppc64"
Index: clang/lib/Driver/ToolChains/Arch/PPC.cpp
===================================================================
--- clang/lib/Driver/ToolChains/Arch/PPC.cpp
+++ clang/lib/Driver/ToolChains/Arch/PPC.cpp
@@ -39,7 +39,12 @@
   if (Arg *A = Args.getLastArg(clang::driver::options::OPT_mcpu_EQ)) {
     StringRef CPUName = A->getValue();
 
-    if (CPUName == "generic")
+    // Clang/LLVM does not actually support code generation
+    // for the 405 CPU. However, there are uses of this CPU ID
+    // in projects that previously used GCC and rely on Clang
+    // accepting it. Clang has always ignored it and passed the
+    // generic CPU ID to the back end.
+    if (CPUName == "generic" || CPUName == "405")
       return getPPCGenericTargetCPU(T);
 
     if (CPUName == "native") {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140080.483146.patch
Type: text/x-patch
Size: 1443 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221215/214f9076/attachment.bin>