[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Michael Buch via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 15 05:40:38 PST 2022


Michael137 added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2095-2097
+        NamedDecl const *ND = Args.TList->getParam(i);
+        defaultParameter = TemplateUtils::isSubstitutedDefaultArgument(
+            CGM.getContext(), TA, ND, Args.Args, Args.TList->getDepth());
----------------
dblaikie wrote:
> Could we pull this snipped out and do it before the switch - so we don't have to repeat it for each different kind of template parameter type?
yup makes sense!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139989/new/

https://reviews.llvm.org/D139989



More information about the cfe-commits mailing list