[PATCH] D140044: [CodeComplete] Complete members of dependent `auto` variables

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 15 03:12:25 PST 2022


ilya-biryukov added inline comments.


================
Comment at: clang/test/CodeCompletion/member-access.cpp:121
 // CHECK-DEP-CHAIN: baseTemplateField : [#T#]baseTemplateField
-// RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:111:41 %s -o - | FileCheck -check-prefix=CHECK-DEP-CHAIN %s
+// RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:119:41 %s -o - | FileCheck -check-prefix=CHECK-DEP-CHAIN %s
 }
----------------
hokein wrote:
> It feels horrible that we have to update all following line numbers whenever we add a new test, no action required here (we can always append a new test, but then tests are not grouped properly)
+1, I would also love to a syntax like `$L-5` or `{{L-5}}` for this in FileCheck. Something short and easy to read.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140044/new/

https://reviews.llvm.org/D140044



More information about the cfe-commits mailing list