[PATCH] D140084: [llvm][test] Split DW_AT_default_value check out of clang/test/

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 14 22:15:03 PST 2022


dblaikie added a comment.

Sorry, should've caught this in review. The clang change needs test coverage in clang, but should verify the emitted it, rather than going all the way down to object code.

The llvm functionality is already tested (since it's just the flag on a template parameter - it's not interesting to test that for different kinds of templates if the flag handling is kind-agnostic anyway)

So instead of this could you adjust the existing clang test to verify IR instead of dwarfdump?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140084/new/

https://reviews.llvm.org/D140084



More information about the cfe-commits mailing list