[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:141
+    // Just for maintain the old order for quick test.
+    return std::tie(this->MU, this->MA, this->TA, this->TU) <
+           std::tie(Other.MU, Other.MA, Other.TA, Other.TU);
----------------
You can remove `this->`


================
Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:211
+    llvm::SmallVector<Policy> SupportedUnMaskedPolicies;
+    SupportedUnMaskedPolicies.emplace_back(
+        Policy(true, false, false, false)); // TU
----------------
I suggested emplace_back because it allows you to remove `Policy(`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139995/new/

https://reviews.llvm.org/D139995