[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

Piyou Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 14 19:05:03 PST 2022


BeMg added inline comments.


================
Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:140
+    // Just for maintain the old order for quick test.
+    return std::tie(this->MU, this->MA, this->TA, this->TU) <
+           std::tie(Other.MU, Other.MA, Other.TA, Other.TU);
----------------
craig.topper wrote:
> Does this need to include PolicyNone and IntrinsicWithoutMU?
In updateNamesAndPolicy, Policy will be reduce as follow

PolicyNone -> TUMU or TA or TU according to function argument
TUM -> TUMA
TAM -> TAMA
MU -> TAMU
MA -> TAMA 

For comparing the order of Policy, (PolicyNone TUM TAM MU MA) doesn't matter. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139995/new/

https://reviews.llvm.org/D139995



More information about the cfe-commits mailing list