[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 14 11:18:35 PST 2022


dblaikie added a comment.

Partly feedback on D139989 <https://reviews.llvm.org/D139989> too - if we could move this logic outside the switch, then it wouldn't need to be done in each different template parameter type? (& then D139989 <https://reviews.llvm.org/D139989> I guess wouldn't be needed - this patch and the other would be subsumed by removing the old logic from distinct switch cases, and putting the new logic that works across different template parameter kinds outside the switch - solving things more generically)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139988/new/

https://reviews.llvm.org/D139988



More information about the cfe-commits mailing list