[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

Wed Dec 14 08:48:06 PST 2022

pmatos added a comment.

In D122215#3995105 <https://reviews.llvm.org/D122215#3995105>, @pmatos wrote:

> In D122215#3991648 <https://reviews.llvm.org/D122215#3991648>, @MoritzS wrote:
>
>> Thanks for the patch! I just tried it out and I think this enables many interesting use cases for WebAssembly when using C/C++.
>>
>> Currently the lowering to wasm does not work when using externrefs when compiling without optimizations. Is that intended behavior?
>
> No - thanks for trying this out. This is definitely not intended behaviour. Somehow I probably didn't test enough without optimizations. I was expecting that the pass mem2reg would get rid of the allocas, but maybe it's not running at those optimization levels. I will have to take a closer look.

Apparently the code forcing mem2reg was lost during a conflict resolution. My apologies, I will add this to the patch asap.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122215/new/

https://reviews.llvm.org/D122215