[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Tue Dec 13 16:30:13 PST 2022

Michael137 added inline comments.

================
Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:37
+// STRICT-NOT:         DW_AT_default_value   (true)
+// DWARF-DUMP:       DW_TAG_template_value_parameter
+// DWARF-DUMP-NEXT:    DW_AT_type    ({{.*}} "bool")
----------------
dblaikie wrote:
> Could consider using `DWARF-DUMP-LABEL` for the TAGs here (& maybe an extra `DWARF-DUMP-LABEL: DW_TAG` at the end) so that the attributes are constrained to be within the same tag? (could use `DWARF-DUMP-DAG` to test attributes in a way that's not order-specific, which would be nice - but I don't know that we do that much in the dwarfdump-driven tests, so not a huge deal)
+1 for the `DAG` directive

Could you elaborate on the `-LABEL` though? IIUC the labels have to match a line in the file uniquely, which the `DW_TAG`s wouldn't

================
Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:41
+// DWARFv4-NEXT:       DW_AT_default_value   (true)
+// STRICT-NOT:         DW_AT_default_value   (true)
+
----------------
dblaikie wrote:
> `NOT` checks should be pretty general (so they don't accidentally pass despite minor differences-from-expectation) so maybe this should `STRICT-NOT: DW_AT_default_value`?
Makes sense!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139953/new/

https://reviews.llvm.org/D139953