[PATCH] D139717: Revert "[Driver] Remove Joined -X"

[Davide Italiano via Phabricator via cfe-commits]

davide added a comment.

In D139717#3987963 <https://reviews.llvm.org/D139717#3987963>, @MaskRay wrote:

>> This change is breaking internal builds. We use the -Xfoo pattern but can now no longer manage whether we allow an unused -Xfoo option to pass as a warning or promote it to an error.
>
> Which `-Xfoo` is used? Do your internal builds reserve `-Xfoo` as a placeholder to do other non-upstream work? Then you can consider `-Gfoo` if your builds don't need the mips semantics.
> Is it possible to clean up the previously-ignored-with-a-warning `-Xfoo`?

@MaskRay -- we can discuss options but we can't just "kill" options willy-nilly just because you don't use them.
A better way of doing this would be marking them as deprecated, wait one release and then remove. Going cold turkey breaks clients you never heard of, and you didn't even warn.

Let's add a test and revert this patch, then we can continue the discussion on how to phase this out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139717/new/

https://reviews.llvm.org/D139717