[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 13 00:05:08 PST 2022
MyDeveloperDay accepted this revision.
MyDeveloperDay added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Format/ContinuationIndenter.cpp:1691
+ (CurrentState.IsCSharpGenericTypeConstraint) || GenericSelection ||
(Style.isJavaScript() && EndsInComma) ||
(State.Line->MustBeDeclaration && !BinPackDeclaration) ||
----------------
I wonder if this says isJavaScript() here because of the
```foo(name: type,name2: type2) syntax```
if that might be the case then given the format you present in your test then maybe it IS correct to have GenericSelection here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139211/new/
https://reviews.llvm.org/D139211
More information about the cfe-commits
mailing list