[PATCH] D139450: Warn about unsupported ibmlongdouble

[Qiu Chaofan via Phabricator via cfe-commits]

qiucf added inline comments.


================
Comment at: clang/test/Driver/lit.local.cfg:26
+if config.ppc_linux_default_ieeelongdouble == "ON":
+  config.available_features.add('ppc_linux_default_ieeelongdouble')
----------------
tuliom wrote:
> qiucf wrote:
> > Can we assume if we are compiling with `-mabi=ieeelongdouble`, then libc++ 'must' be built with the same long double ABI? If I understand correctly, they're unrelated.
> @qiucf I didn't understand this part. Are you suggesting to remove the long double warnings because the way the compiler was built is unrelated to the way libc++ was built?
Ah, I misunderstood meaning of 'defaults to IEEE long double' in last review. We can assume 'how the compiler was built' is the same as 'how the libc++ was built'.

But when 'how the libc++ was built' conflicts with 'how the compiler compiles current program', we expect a warning, right? If so, this looks reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139450/new/

https://reviews.llvm.org/D139450