[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 12 14:20:22 PST 2022


owenpan added a comment.

In D139801#3989812 <https://reviews.llvm.org/D139801#3989812>, @HazardyKnusperkeks wrote:

> My idea would be hardcoded `friend` as first entry, regardless of the chosen sequence.
> But others may have a different opinion on that.

It would be confusing with `QAS_Right` and inconsistent with `QAS_Custom` which allows e.g. `inline`, `static`, and `volatile` to be placed after the type. IMO we should just add `friend` to `QualifierOrder` as this patch currently intends to do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139801/new/

https://reviews.llvm.org/D139801



More information about the cfe-commits mailing list