[PATCH] D138210: [clang] Require parameter pack to be last argument in concepts.

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 12 11:46:19 PST 2022


dblaikie added a comment.

In D138210#3989385 <https://reviews.llvm.org/D138210#3989385>, @luken-google wrote:

> committed at afd800fc5679ccfe6f32b097586c658628500867 <https://reviews.llvm.org/rGafd800fc5679ccfe6f32b097586c658628500867>

For future reference it's handy to include the "Differential Revision: https://reviews.llvm.org/DXXXX" (`arc` will create this for you, if you use that) in the commit message both so folks looking at the commit can find the review/know that it was reviewed on Phab, and that way Phab will auto-close the review and include a link to the commit.

Also I think we're still using the "PR" prefix predominantly for bug references, rather than the "GH" suffix you've used here (handy for consistency - easier to search up the bugs if the prefix is more consistent).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138210/new/

https://reviews.llvm.org/D138210



More information about the cfe-commits mailing list