[PATCH] D139868: [clang][dataflow] Change the diagnoser API to receive a correctly typed lattice element

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 12 11:44:24 PST 2022


ymandel accepted this revision.
ymandel added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:134
+    PostVisitCFG =
+        [=](ASTContext &Context, const CFGElement &Element,
+            const TransferStateForDiagnostics<typename AnalysisT::Lattice>
----------------
nit: I think capturing by move is a bit better, since Arg is passed by copy to `withPostVisitCFG`: `[Arg = std::move(Arg)]`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139868/new/

https://reviews.llvm.org/D139868



More information about the cfe-commits mailing list