[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

Kai Nacke via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 12 09:56:12 PST 2022


Kai added a comment.

In D139444#3978189 <https://reviews.llvm.org/D139444#3978189>, @uweigand wrote:

> In D139444#3975182 <https://reviews.llvm.org/D139444#3975182>, @probinson wrote:
>
>> The changes in this patch assume that there aren't any possible suffixes after the `-zos` part of the triple (no version numbers, like you might find with darwin or macos, and nothing like `-elf` or `-eabi` like some targets have).  If there are suffixes, I'll happily revise to put `{{.*}}` after everything.
>
> I think for consistency with other targets, and to be safe for future extensions of the target triple, it would be better to add the `{{.*}}`

There will be suffixes after the `-zos` part. Thanks for adding the pattern at the end.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139444/new/

https://reviews.llvm.org/D139444



More information about the cfe-commits mailing list