[PATCH] D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 12 09:30:56 PST 2022


shafik added a comment.

If I am reading the code correctly it looks like if the call to `(*I)->isValueDependent()` is true then the temporary will not be created and therefore we should not be attempting to access the slot.

If this is the case then maybe the checking in `EvaluateWithSubstitution(...)` needs to be more carefully done?

I am not familiar with this code but I don't know if you analysis provides a convincing case the assert should be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139713/new/

https://reviews.llvm.org/D139713



More information about the cfe-commits mailing list