[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 12 08:16:48 PST 2022


HazardyKnusperkeks added a comment.

I'm normally way more lenient than the most to add features, but here I have to ask do you want it so that you can get `friend` always as first, or do you really want to be able to put `friend` anywhere in the sequence? If only the first, I'd say we do that without adding this option.

I had actually to look up that you can put `friend` basically anywhere, all examples, tutorials, etc. put it in front. I would discourage that clang-format puts it anywhere else, even though it is valid C++.

Technically: Do we need/want a config parse test for friend?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139801/new/

https://reviews.llvm.org/D139801



More information about the cfe-commits mailing list