[PATCH] D139835: [include-cleaner] Include the reference type when printing the SymbolReference.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 12 05:42:29 PST 2022
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/include-cleaner/lib/Types.cpp:49
// isn't completely useless (and distinguishes SymbolReference from Symbol).
- return OS << R.Target << "@0x"
+ return OS << R.Target << "@" << R.RT << "@0x"
<< llvm::utohexstr(
----------------
i think this might read better as:
```
OS << R.RT << " reference to " << R.Target << "@0x" << ...;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139835/new/
https://reviews.llvm.org/D139835
More information about the cfe-commits
mailing list