[PATCH] D139006: [UpdateTestChecks] Match define for labels

Sebastian Neubauer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 12 04:22:41 PST 2022


sebastian-ne added a comment.

In D139006#3988215 <https://reviews.llvm.org/D139006#3988215>, @mkazantsev wrote:

> So now every single test needs to be regenerated? It'll create straw diff from nowhere...

We don’t need to regenerate every test.
Similar to how we don’t reformat all of LLVM after a change in clang-format, we can just do that when regenerating tests when they have changes anyway.
So, the churn is that we have extra changes when regenerating a test for a patch.
(In my personal experience there are often extra changes anyway, because metadata was added or similar changes that pass the old CHECKs but show up on a freshly regenerated test.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139006/new/

https://reviews.llvm.org/D139006



More information about the cfe-commits mailing list