[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

Pierre van Houtryve via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 12 03:21:17 PST 2022


Pierre-vh added a comment.

In D139608#3982494 <https://reviews.llvm.org/D139608#3982494>, @jcranmer-intel wrote:

> I don't normally handle name mangling, so I can't comment too much here, but I will note that Itanium ABI is planning on using DF16b for `std::bfloat16_t`: https://github.com/itanium-cxx-abi/cxx-abi/pull/147

This is just a NFC so if we're sure targets will soon start to use different mangled names then I can just abandon the commit
I just proposed this change because currently there's no reason not to have a default value for this function


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139608/new/

https://reviews.llvm.org/D139608



More information about the cfe-commits mailing list