[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added a comment.

I don't know if adding two options at once (and I think you want to add a third), splitting that up might be a better idea.

Anyway you need to tun `clang/docs/tools/dump_format_style.py` and add an entry in the changelog.



================
Comment at: clang/include/clang/Format/Format.h:542
+  /// \code
+  ///   true:
+  ///   template <typename T>
----------------
We have both, but I like the variant with `true` and `false` next to each other, not below.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1105
   }
+
   nextToken();
----------------
Unrelated.


================
Comment at: clang/unittests/Format/FormatTest.cpp:2911
+               "  a + b;\n"
+               "};");
+  // TODO: support BraceWrapping.AfterRequiresExpression.
----------------
You need to add the Style.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139786/new/

https://reviews.llvm.org/D139786