[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

[Gheorghe-Teodor Bercea via Phabricator via cfe-commits]

doru1004 added a comment.

In D139723#3984846 <https://reviews.llvm.org/D139723#3984846>, @jdoerfert wrote:

> I'm not 100% sure if this was excluded on purpose or not. FWIW, in C, these functions are not defined in math.h (https://en.cppreference.com/w/c/numeric/math/abs), but in C++ they are (https://en.cppreference.com/w/cpp/numeric/math/abs).
>
> Once we enable libm_gpu it might not make a difference. For now, I'm OK with this if it doesn't break peoples code.

This fixes the case where we have a C file with offloading OpenMP in it that calls these functions. I'm not sure I see another way to do this in the current setup but I'm open to other solutions if this one breaks things unexpectedly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139723/new/

https://reviews.llvm.org/D139723