[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

In D139723#3984880 <https://reviews.llvm.org/D139723#3984880>, @arsenm wrote:

> In D139723#3984846 <https://reviews.llvm.org/D139723#3984846>, @jdoerfert wrote:
>
>> I'm not 100% sure if this was excluded on purpose or not. FWIW, in C, these functions are not defined in math.h (https://en.cppreference.com/w/c/numeric/math/abs), but in C++ they are (https://en.cppreference.com/w/cpp/numeric/math/abs).
>>
>> Once we enable libm_gpu it might not make a difference. For now, I'm OK with this if it doesn't break peoples code.
>
> Should there be a separate builtin header corresponding to stdlib.h?

Probably. And we want to finish the libc_gpu/libm_gpu work to provide the definitions late (in LTO mode)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139723/new/

https://reviews.llvm.org/D139723