[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 9 10:01:31 PST 2022


jdoerfert added a comment.

I'm not 100% sure if this was excluded on purpose or not. FWIW, in C, these functions are not defined in math.h (https://en.cppreference.com/w/c/numeric/math/abs), but in C++ they are (https://en.cppreference.com/w/cpp/numeric/math/abs).

Once we enable libm_gpu it might not make a difference. For now, I'm OK with this if it doesn't break peoples code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139723/new/

https://reviews.llvm.org/D139723



More information about the cfe-commits mailing list