[PATCH] D139717: Revert "[Driver] Remove Joined -X"

Roy Sundahl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 9 07:16:13 PST 2022


rsundahl created this revision.
Herald added a project: All.
rsundahl requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This change is breaking internal builds. We use the -Xfoo pattern but can
now no longer manage whether we allow an unused -Xfoo option to pass as a
warning or promote it to an error.

This reverts commit 98615fd376cea15af21e120e0e3ffa5ba68c2b6d <https://reviews.llvm.org/rG98615fd376cea15af21e120e0e3ffa5ba68c2b6d>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139717

Files:
  clang/include/clang/Driver/Options.td


Index: clang/include/clang/Driver/Options.td
===================================================================
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -844,6 +844,7 @@
 def Xpreprocessor : Separate<["-"], "Xpreprocessor">, Group<Preprocessor_Group>,
   HelpText<"Pass <arg> to the preprocessor">, MetaVarName<"<arg>">;
 def X_Flag : Flag<["-"], "X">, Group<Link_Group>;
+def X_Joined : Joined<["-"], "X">, IgnoredGCCCompat;
 def Z_Flag : Flag<["-"], "Z">, Group<Link_Group>;
 def all__load : Flag<["-"], "all_load">;
 def allowable__client : Separate<["-"], "allowable_client">;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139717.481646.patch
Type: text/x-patch
Size: 628 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221209/cda77124/attachment.bin>


More information about the cfe-commits mailing list