[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 9 01:52:52 PST 2022


cor3ntin added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:129-130
   InGroup<DiagGroup<"unicode-whitespace">>;
 def warn_utf8_symbol_homoglyph : Warning<
   "treating Unicode character <U+%0> as identifier character rather than "
   "as '%1' symbol">, InGroup<DiagGroup<"unicode-homoglyph">>;
----------------
tahonermann wrote:
> I think this diagnostic should also have an "an" before "identifier" if you wish to take on correcting it as well.
Done https://github.com/llvm/llvm-project/commit/9e2dc984ba1b25625e6ddc38ba681b194172379a 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137051/new/

https://reviews.llvm.org/D137051



More information about the cfe-commits mailing list